nextUntil, prevUntil and parentsUntil should accept more then just selectors

[anonymous]

Just as the title says. One way to make sure the "Until" methods accept more then just selectors is to use the filter method instead of jQuery().is from line 4556 from:

while ( cur && cur.nodeType !== 9 && ( until === undefined || cur.nodeType !== 1 || !jQuery( cur ).is( until )) ) {

To:

while ( cur && cur.nodeType !== 9 && ( until === undefined || cur.nodeType !== 1 || !jQuery( cur ).filter(until)[0] )) {

Now, correct me if I'm wrong here. But assuming you are comparing two DOM nodes to each other. Wouldn't it be a lot faster to compare those right away, so a new jQuery instance won't be created on each iteration? This way you would get something like:

while ( cur && cur.nodeType !== 9 && ( until === undefined || cur.nodeType !== 1 || !( cur === until || jQuery( cur ).filter( until )[0])) ) {

Heck, we could even use matchesSelector between them with something like this:

!( cur === until || ( typeof until === "string" && jQuery.find.matchesSelector( cur, until ) ) || jQuery( cur ).filter( until )[0])

Any thoughts?

[jitter]

To increase the chances for this to make into the core you should make a pull request with the needed changes

---

​http://docs.jquery.com/Tips_for_jQuery_Bug_Patching
​http://docs.jquery.com/Getting_Involved

[anonymous]

​http://jsperf.com/nextuntil-tests

Created a small perf on this ticket. I think it could be optimized and enhanced.

[anonymous]

​http://forum.jquery.com/topic/nextuntil-prevuntil-and-parentsuntil-should-accept-more-then-just-selectors

[snover]

Increasing priority & retargeting due to potential performance benefits.

[john]

Let's look at this for 1.7.

[JRSchild]

As of jQuery 1.6 and the updated is() and find() methods this already works:

nextUntil: ​http://jsfiddle.net/asz7m/
prevUntil: ​http://jsfiddle.net/mXmSS/
parentsUntil: ​http://jsfiddle.net/n77ua/

Should the documentation and test-cases be updated?

[timmywil]

Good point! Thanks JRSchild

[addyosmani]

Working on this at the moment. We'll make sure to post updated examples, signatures and wordage, JRSchild. Thanks!

[addyosmani]

I've updated the docs on .nextUntil(), .prevUntil() and .parentsUntil() to reflect the changes in behaviour.