Bug Tracker

Opened 8 years ago

Closed 8 years ago

Last modified 7 years ago

#8044 closed bug (fixed)

Unused variable "rnonword"?

Reported by: iszak.bryan@… Owned by: Rick Waldron
Priority: low Milestone: 1.5
Component: core Version: 1.5rc1
Keywords: Cc:
Blocked by: Blocking:

Description

Upon looking into jQuery 1.5 RC1 source I noticed a variable called "rnonword" which doesn't appear to be used throughout jQuery, I have also checked the trunk and it doesn't appear to be used there either. Is this a mistake or is it used?

Change History (4)

comment:1 Changed 8 years ago by addyosmani

Priority: undecidedlow
Status: newopen

I notice that rnonword was used to check for non-word characters on line 180 of the source in jQuery 1.4.4 but you're correct in saying it's nowhere else to be found after its defined in 1.5. It's quite trivial to remove and should be safe to get rid of before we finalize the 1.5 release. I'll keep this open as a reminder.

comment:2 Changed 8 years ago by Rick Waldron

Owner: set to Rick Waldron
Status: openassigned

https://github.com/jquery/jquery/pull/207

Interesting side note: I did that in cloud9ide on a cr-48

comment:3 Changed 8 years ago by paul.irish

I did that in cloud9ide on a cr-48

baller.

comment:4 Changed 8 years ago by jitter

Component: unfiledcore
Milestone: 1.next1.5
Resolution: fixed
Status: assignedclosed

Landed 8d05055.

The regex in question was a left over from a - post-1.5b1 - removed selector speed up branch.

Note: See TracTickets for help on using tickets.