Bug Tracker

Opened 7 years ago

Closed 7 years ago

#8017 closed bug (fixed)

$.fn.domManip woes - 1.5b is 80% slower

Reported by: danheberden Owned by: Rick Waldron
Priority: blocker Milestone: 1.5
Component: manipulation Version: 1.5b1
Keywords: Cc:
Blocked by: Blocking:

Description

http://jsperf.com/dh-dommanip-tribulations

it's not clone (http://jsperf.com/dh-jquery-1-5b-clone) - but it is. Using clone when it shouldn't be run is making for a huge perf hit.

Stemmed from: #8013

Change History (6)

comment:1 Changed 7 years ago by jitter

Component: unfiledmanipulation
Priority: undecidedblocker
Status: newopen

comment:2 Changed 7 years ago by danheberden

Here's the perf/fix with rwaldrons goodies: http://jsperf.com/dh-dommanip-tribulations/3

comment:3 Changed 7 years ago by john

Milestone: 1.next1.5

comment:4 Changed 7 years ago by john

See also: #8013.

comment:5 Changed 7 years ago by Rick Waldron

Owner: set to Rick Waldron
Status: openassigned

I've abstracted copyCloneEvent to accept a single origin and clone DOM node, instead of collections. This frees us from making any calls to find("*"). Created jQuery.clone( elem, [ dataAndEvents, deepDataAndEvents ]) which acts as the brains for jQuery.fn.clone(). [ dataAndEvents, deepDataAndEvents ] Are both true by default.

https://github.com/jquery/jquery/pull/200

Last edited 7 years ago by Rick Waldron (previous) (diff)

comment:6 Changed 7 years ago by john

Resolution: fixed
Status: assignedclosed

Landed.

Note: See TracTickets for help on using tickets.