Skip to main content

Bug Tracker

Side navigation

#7974 closed enhancement (fixed)

Opened January 14, 2011 08:05PM UTC

Closed April 16, 2011 04:18PM UTC

Cleanup effects.js to improve performances and reduce filesize

Reported by: lrbabe Owned by:
Priority: low Milestone: 1.6
Component: effects Version: 1.4.4
Keywords: Cc:
Blocked by: Blocking:

I've opened a pull request of small changes to effect.js that:

  • reduce function calls, calls in particular
  • reduce number of out-of-scope variables lookups
  • cache more variables to reduce file-size once minified

It yields some interesting performance improvement, as demonstrated in this example: (remove patched effects.js in "manage ressources" menu to see the difference)

  • function calls: 1177 -> 1022 = 13% better
  • average execution time: 26.1 -> 23.4 = 10% better

/!\\ example might be unrealistic /!\\

As a side effect, it keeps animations synchronized and thus fixes #7917 and addresses a similar problem to #6281

Attachments (0)
Change History (4)

Changed January 14, 2011 11:55PM UTC by jitter comment:1

component: unfiledeffects
milestone: 1.next1.6
priority: undecidedlow
type: bugenhancement

Changed January 18, 2011 06:18PM UTC by snover comment:2

status: newopen

Changed February 08, 2011 02:11PM UTC by lrbabe comment:3

Additional benefits with last commits:

  • reduce function calls even more
  • simplifies easing resolution code
  • add some comments and improve code readability here and there

Changed April 16, 2011 04:18PM UTC by john comment:4

resolution: → fixed
status: openclosed

This particular pull request was closed - a new open was opened up (and closed) just recently.