Calling $.fn.data without arguments on a non-DOMelement in 1.4.4

[timmolendijk]

Try the following code in 1.4.3 and then in 1.4.4:

$({tim: 28}).data()

In 1.4.3 the expected data object is returned, in 1.4.4 a TypeError in thrown: "Cannot read property 'length' of undefined"

The problem is in line 1250, in which it is assumed that the data object has an "attributes" property (which is obviously a valid assumption for DOM nodes with nodeType 1 but not for many other object types).

[boushley]

Here's a simple jsFiddle for this use case ​http://jsfiddle.net/boushley/CCdtM/.

[Rick Waldron]

Confirmed

[snover]

Calling $.fn.data on a plain JS object with no argument will just return the JS object. Is there actually a use case here?

[timmolendijk]

Use case; sometimes it's a custom (not necessarily plain) JS object, sometimes it's a DOM element. That's where the $.data API shines, as you can just treat them all the same. This bug messes up this unity.

[snover]

I wish, I wish, I wish this wasn’t a regression.

[snover]

​pull request

[john]

Landed.

[jitter]

Move fixed tickets to appropriate milestone