Bug Tracker

Changes between Initial Version and Version 1 of Ticket #7442, comment 25


Ignore:
Timestamp:
Jun 14, 2012, 7:03:58 PM (7 years ago)
Author:
mikesherov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #7442, comment 25

    initial v1  
    1 just thinking out loud here: what if at the end of the animation we set the top border to "1px solid transparent" and the margin-top to "-1px"? Is that a crazy hack?
     1~~~just thinking out loud here: what if at the end of the animation we set the top border to "1px solid transparent" and the margin-top to "-1px"? Is that a crazy hack?~~~
     2
     3Yes, that was a crazy hack that doesn't really work. I'm with gnarf here. This seems very hard to resolve with a small amount of code. Margin collapse is a known phenomenom that isn't always undesired.
     4
     5I'm changing my vote to -1, because the number of ways margin collapse can happen, both desired and undesired. Also, because of the multiple ways in wish we could even attempt to fix this, someone is inevitable complain we fixed it the wrong way.
     6
     7I say, if you don't want margin collapse, don't write code that has margin collapse. There doesn't seem to be anythingwe can, nor should, do here.