$('<div>ff</div>').closest('[attr]'); raises exception in all browsers

[Már Örlygsson]

raises exceptions...

$('<div>ff</div>').closest('[foo]')
$('<div anyAttr></div>').closest('[foo]')

does not raise exception...

$('<div></div>').closest('[foo]')

​test case

[Rick Waldron]

Thanks for taking the time to contribute to the jQuery project! Please provide a reduced jsFiddle test case, thanks again - and party on!

Please help me understand what you're trying to accomplish - the example you've given is actually invalid.

Additionally, test against the jQuery 0 GIT version to ensure the issue still exists. Be Excellent to eachother!

[anonymous]

Test: ​http://jsfiddle.net/PjbQA/

[Rick Waldron]

You can't call closest() on a document fragment that hasn't actually been appended into the DOM. You CAN create and append an element and then call it:

​http://jsfiddle.net/rwaldron/PjbQA/1/

This is not a jQuery bug.

[dmethvin]

Seems like it should be possible to use .closest() on disconnected nodes, and in general it is except for this case with attributes.

[dmethvin]

OK, I got this in the IE8 debugger. The problem is that Sizzle walks up to the document and then in ATTR tries to call elem.getAttribute("lang") but there is no getAttribute method on document. I guess we could check for elem.getAttribute being present?

Perhaps the bigger question is how we get to the document on a disconnected element...

[Már Örlygsson <[email protected]…>]

Checking for getAttribute being present sounds like a good fix.

Please try to gt this fix into 1.4.4

[snover]

There is no document on a disconnected node; at best only a fragment (nodeType 11). This is very similar to #7142.

[Már Örlygsson <[email protected]…>]

This is still broken in jQuery 1.5

Ticket #7142 did not fix this one.

[Már Örlygsson <[email protected]…>]

Confirmed that this bug still present in jQuery 1.5.1

[timmywil]

​pull request here

[timmywil]

#8759 is a duplicate of this ticket.

[timmywil]

The pull request does not fix this issue when doing $('<div>text</div>').after(...)

[john]

Landed.