#7220 closed bug (fixed)
Next Sibling combined with :last is failing.
Reported by: | marioestrada | Owned by: | john |
---|---|---|---|
Priority: | blocker | Milestone: | 1.4.4 |
Component: | selector | Version: | 1.4.3 |
Keywords: | regression | Cc: | |
Blocked by: | Blocking: |
Description
At techspot.com I have a selector that runs after more stories have been loading using ajax and where the page should scroll to the first loaded story, but with 1.4.3 it is no longer working.
The selector is '.next_page:last + .headline_story' it used to work on 1.4.2 but not anymore, it doesn't find any objects. Using the alternative $('.next_page:last').next('.headline_story') works but still I think this is a bug since it used to work.
Change History (8)
comment:1 Changed 12 years ago by
comment:2 Changed 12 years ago by
Component: | unfiled → selector |
---|---|
Keywords: | regression added |
Priority: | undecided → blocker |
Status: | new → open |
comment:3 Changed 12 years ago by
I threw together this tiny plugin to help debug issues like this:
// Log the selector used to select elements to each selected element, // otherwise to the body. Hover over logged selectors to highlight // stuff all fancy-like (note: don't select SPAN elements because this // creates them all over the place!) - Cowboy $.fn.logSelector = function() { var elems = $( '<span>' + this.selector + ' [' + this.length + ']</span>' ) .appendTo( this.length ? this : 'body' ); this.length && elems.hover(function(e){ elems.parent().andSelf().toggleClass( 'hover', e.type === 'mouseenter' ); }); return this; };
See it in use here: http://jsfiddle.net/cowboy/skGZx/
comment:4 Changed 12 years ago by
Also, the link in my last comment has a bunch of test cases that fail in 1.4.3 but work in 1.4.2 - please add more!
comment:5 Changed 12 years ago by
Owner: | set to ajpiano |
---|---|
Status: | open → assigned |
comment:6 Changed 12 years ago by
Owner: | changed from ajpiano to john |
---|
comment:7 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Make sure that +, >, ~ leading, rooted, selectors go to the old engine. Thanks to @rkatic for the catch! Fixes #7220.
Changeset: 424500bcf068a234b13cd9ef33d94580c35eeb86
Here is a test case: http://jsfiddle.net/Xy9GL/ with the + selector not working.
And working using .next(): http://jsfiddle.net/n5Nh5/1/