Bug Tracker

Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#7220 closed bug (fixed)

Next Sibling combined with :last is failing.

Reported by: marioestrada Owned by: john
Priority: blocker Milestone: 1.4.4
Component: selector Version: 1.4.3
Keywords: regression Cc:
Blocked by: Blocking:


At techspot.com I have a selector that runs after more stories have been loading using ajax and where the page should scroll to the first loaded story, but with 1.4.3 it is no longer working.

The selector is '.next_page:last + .headline_story' it used to work on 1.4.2 but not anymore, it doesn't find any objects. Using the alternative $('.next_page:last').next('.headline_story') works but still I think this is a bug since it used to work.

Change History (8)

comment:1 Changed 12 years ago by marioestrada

Here is a test case: http://jsfiddle.net/Xy9GL/ with the + selector not working.

And working using .next(): http://jsfiddle.net/n5Nh5/1/

comment:2 Changed 12 years ago by snover

Component: unfiledselector
Keywords: regression added
Priority: undecidedblocker
Status: newopen

comment:3 Changed 12 years ago by cowboy

I threw together this tiny plugin to help debug issues like this:

// Log the selector used to select elements to each selected element,
// otherwise to the body. Hover over logged selectors to highlight
// stuff all fancy-like (note: don't select SPAN elements because this
// creates them all over the place!) - Cowboy

$.fn.logSelector = function() {
    var elems = $( '<span>' + this.selector + ' [' + this.length + ']</span>' )
        .appendTo( this.length ? this : 'body' );
    this.length && elems.hover(function(e){
        elems.parent().andSelf().toggleClass( 'hover', e.type === 'mouseenter' );
    return this;

See it in use here: http://jsfiddle.net/cowboy/skGZx/

Version 2, edited 12 years ago by cowboy (previous) (next) (diff)

comment:4 Changed 12 years ago by cowboy

Also, the link in my last comment has a bunch of test cases that fail in 1.4.3 but work in 1.4.2 - please add more!

comment:5 Changed 12 years ago by snover

Owner: set to ajpiano
Status: openassigned

comment:6 Changed 12 years ago by ajpiano

Owner: changed from ajpiano to john

comment:7 Changed 12 years ago by jeresig

Resolution: fixed
Status: assignedclosed

Make sure that +, >, ~ leading, rooted, selectors go to the old engine. Thanks to @rkatic for the catch! Fixes #7220.

Changeset: 424500bcf068a234b13cd9ef33d94580c35eeb86

comment:8 Changed 12 years ago by john

#7277 is a duplicate of this ticket.

Note: See TracTickets for help on using tickets.