.not() on contents() has problems with selector

[leo]

there's seems to be a problem using not() with selectors:

I have a div ($foo) with textnodes and buttons.

$foo.contents().not($j('button')) works (returns all textnodes) $foo.contents().not('button') does not work (returns empty)

[anonymous]

Please see this fiddle: ​http://jsfiddle.net/DJkVx/6/

[snover]

This is because the winnow function filters out nodes that are not of type NODE_ELEMENT when the qualifier passed is a string.

[snover]

Retargeting due to severity of regressions in 1.4.3.

[dmethvin]

After retrieving text nodes, any function that filters using a selector string will remove text nodes. To avoid that, you can use .filter(function) and remove anything that isn't a text node, rather than using the button selector.

[john]

There wasn't a 1.4.5 release, was actually 1.5.

[john]

There was no 1.4.5 release, was actually 1.5.

[anonymous]

I believe there's still an issue here.

if($('div').not('.foo,.bar')) returns what looks to be empty objects for the filtered selectors instead of completely removing them

on the other hand if(!$('div').is('.foo,.bar')) works just fine, shouldn't it be the same?