Skip to main content

Bug Tracker

Side navigation

#7147 closed bug (duplicate)

Opened October 11, 2010 02:52PM UTC

Closed October 11, 2010 08:27PM UTC

1.4.3 RC1 breaks jQuery UI dialog

Reported by: jagid Owned by: john
Priority: blocker Milestone: 1.4.3
Component: traversing Version: 1.4.2
Keywords: Cc:
Blocked by: Blocking:
Description

I know that there is a jQuery UI element to this issue but as the below code works with 1.4.2 a change in 1.4.3 is causing the issue. With the below code the dialog does not display unless the buttons line is removed.

<div id="testdiv">Test content<div>

<link href="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.4/themes/smoothness/jquery-ui.css" rel="stylesheet" type="text/css" />

<script type="text/javascript" src="http://code.jquery.com/jquery-1.4.3rc1.js"></script>

<script type="text/javascript" src="http://ajax.googleapis.com/ajax/libs/jqueryui/1.8.4/jquery-ui.min.js"></script>

<script type="text/javascript">

$(document).ready(function () {

$("#testdiv").dialog({

buttons: { "OK": function () { alert($(this).html()); }}

});

});

</script>

Attachments (0)
Change History (3)

Changed October 11, 2010 06:50PM UTC by snover comment:1

owner: → snover
priority: undecidedblocker
status: newassigned

Issue only occurs with buttons property active. Looks like jQuery 1.4.3 checks for properties on cur in .closest but cur is not always defined, so it generates an error. Line 4193 needs a !cur in the conditional. Live test case

Changed October 11, 2010 08:02PM UTC by snover comment:2

component: unfiledtraversing
need: ReviewCommit
owner: snoverjohn
status: assignednew

Changed October 11, 2010 08:27PM UTC by john comment:3

resolution: → duplicate
status: newclosed

Duplicate of #7142.