Bug Tracker

Opened 13 years ago

Closed 13 years ago

#7067 closed bug (fixed)

Incorrect effects-unit-test could conceal failures

Reported by: bugbegone Owned by:
Priority: undecided Milestone: 1.4.3
Component: effects Version: 1.4.2
Keywords: fx unit test Cc:
Blocked by: Blocking:


In test/unit/effect.js on Line 519 the superfluous

+ "px"


notEqual(jQuery.css(this, "height") + "px", old_h, ....

should be removed.

css(...) returns the value with units intact anyway. Thus if jQuery.css(this, "height") and old_h should happen to have the same value the notEqual-check can't catch this because the appended px string causes the values to always be different.

Change History (1)

comment:1 Changed 13 years ago by john

Priority: undecided
Resolution: fixed
Status: newclosed

Ha, missed this bug report but I actually just fixed this here: http://github.com/jquery/jquery/commit/2f603359fecca5b4873c45775b293702a2c651e3

Note: See TracTickets for help on using tickets.