jQuery.fn.show() changes "display" style when inline

[chrisobrien]

Visit ​http://jsfiddle.net/GG8FD/ for a demonstration of this bug.

When jQuery.fn.show() is called on an element that is not hidden and that element has an inline CSS "display" style (as shown below), show() sets the "display" to "block":

<div id="cell" style="display:table-cell"></div>

<script type="text/javascript">

alerts "table-cell"

alert($("#cell").css("display"));

$("#cell").show();

alerts "block"

alert($("#cell").css("display"));

</script>

However, when show() is called on an element that is not hidden and that element has its "display" set in a stylesheet, show() does not change its "display":

<style type="text/css">

#cell {

display:table-cell;

}

</style>

<div id="cell"></div>

<script type="text/javascript">

alerts "table-cell"

alert($("#cell").css("display"));

$("#cell").show();

alerts "table-cell"

alert($("#cell").css("display"));

</script>

Expected result: first example (inline "display" style) should not change the "display" to "block" and instead should behave the same as second example ("display" in stylesheet).

[jaakko.salomaa]

Also, jQuery.fn.show() sets the element.style.display value to "" if getComputedStyle() fails, which it sometimes does in Firefox if used in a currently hidden frame. The following happens in show():

var old = jQuery.data(this[i], "olddisplay");

old -> null

this[i].style.display = old || "";

this[i].style.display -> ""

if ( jQuery.css(this[i], "display") === "none" ) { ... }

This block doesn't get executed because somewhere along jQuery.fn.css() call tree, getComputedStyles() fumbles.

// Set the display of the elements in a second loop
// to avoid the constant reflow
for ( var j = 0, k = this.length; j < k; j++ ) {
    this[j].style.display = jQuery.data(this[j], "olddisplay") || "";
}

this[j].style.display -> "" for a second time

In certain cases, this causes the element either to remain hidden or to eve disappear if it wasn't previously hidden.

[snover]

Duplicate of #2185.