jQuery.fn.add adds incorrect elements when given select or form DOM nodes

[scott_h]

Some DOM elements have a length property -- e.g., select box elements and forms, which alias their options and elements collections respectively -- and these cause jQuery.makeArray to consider them as arrays rather than array items. This has the effect that jQuery().add(mySelectElement) returns a list of option elements instead of a single select element.

[scott_h]

This affects Chrome, Safari, Firefox, IE7 and IE8 (Opera untested).

[scott_h]

Fixed test - the first one is incorrect, so please use the second one.

[scott_h]

Here's the fix I propose for this bug:

​http://github.com/shghs/jquery/commit/904ef97ed1175b6f899efe9240381c8b0638667d

[dmethvin]

I agree with this patch, but there is a test case that fails when it is applied (Pass makeArray a form (treat as elements)) that indicates it is intended. The api docs don't specifically mention this behavior as a feature, though. Also, the one place I could think of where it might be depended upon, serializeArray, already checks for form.elements so it doesn't need makeArray to do this AFAICT.

[scott_h]

This is fixed in v1.6, duplicates #6912.

[Timmy Willison]

Thank you scott_h! You're right.

[Timmy Willison]

Duplicate of #6912.