Bug Tracker

Opened 10 years ago

Last modified 8 years ago

#6782 closed enhancement

carefully allow more strings to use innerHTML — at Version 15

Reported by: cmcnulty Owned by: wookiehangover
Priority: blocker Milestone: 1.7
Component: manipulation Version: 1.4.4
Keywords: html, 1.7-discuss Cc:
Blocked by: Blocking:

Description (last modified by Rick Waldron)

.html() uses rnocache to determine both if a snippet should be cached by buildFragment() and also whether or not html() should use append or innerHTMLto insert the snippet. The problem is that buildFragment requires more stringent rules than innerHTML does, and therefore fewer strings use innerHTML than otherwise could, and that hurts performance, particularly by stripping all snippets with an <option anywhere in the string.

I therefore suggest a new regex rule explicitly to determine if innerHTML or append method should be used. Not only will the improve performance, but it also makes the code cleaner, more readable and make more sense.

The new regex only excludes <style and <script for the following documented reasons:

style: http://dev.jquery.com/ticket/5977

script: http://poeticcode.wordpress.com/2007/10/03/innerhtml-and-script-tags/

<object and <embed

Have tests added to them, and cause no new failures in IE7, FF3.7 or Chrome 5.

I discussed these changes a while back in this topic:

http://forum.jquery.com/topic/html-performance-vs-cruft#14737000000784382

Change History (17)

Changed 10 years ago by cmcnulty

Attachment: html_innerhtml_patch.txt added

Changed 10 years ago by cmcnulty

comment:1 Changed 9 years ago by snover

Milestone: 1.4.3

Resetting milestone to future.

comment:2 Changed 9 years ago by snover

Milestone: 1.5
Priority: high
Status: newopen
Version: 1.4.21.4.4

comment:3 Changed 9 years ago by cmcnulty

Created a jsperf test to show the performance increase:

http://jsperf.com/tweaks-to-rnocache

I extend jquery to create a .html2() which is identical to .html() except that rather than using nocache it uses a regex test that it optimized for .html()

comment:5 Changed 9 years ago by john

Milestone: 1.next

comment:6 Changed 9 years ago by john

#7156 is a duplicate of this ticket.

comment:7 Changed 9 years ago by john

#7338 is a duplicate of this ticket.

comment:8 Changed 9 years ago by wookiehangover

Owner: set to wookiehangover
Status: openassigned

I'm gonna take crack at this.

comment:9 Changed 9 years ago by cmcnulty

Glad to hear this has been assigned. I've been pushing for this change for a long time and am very familiar with at least some of the issues involved. Feel free to let me know if you have any questions! I'm not convinced that this little change is going to be a cure-all for the #7341 problems, but it should help a bit in IE 7,8,9.

comment:10 Changed 9 years ago by john

Keywords: 1.7-discuss added

Nominating ticket for 1.7 discussion.

comment:11 Changed 9 years ago by jaubourg

Description: modified (diff)

+0, What about IE6? Need proof.

comment:12 Changed 9 years ago by ajpiano

Description: modified (diff)

+1, If the perf here is demonstrable in IE, then let's go for it.

comment:13 Changed 9 years ago by timmywil

Description: modified (diff)

+1, I'm all for perf improvements.

comment:14 in reply to:  11 Changed 9 years ago by cmcnulty

Replying to jaubourg:

+0, What about IE6? Need proof.

IE6 sees near 100% performance increase, passes all unit tests.

comment:15 Changed 9 years ago by Rick Waldron

Description: modified (diff)

@cmcnulty can you provide a test case that we can view in IE6?

Note: See TracTickets for help on using tickets.