Side navigation
#6704 closed enhancement (invalid)
Opened June 22, 2010 08:09AM UTC
Closed December 30, 2010 02:51AM UTC
Last modified January 31, 2011 05:54PM UTC
In efficient use of the dedicated body element selector
| Reported by: | V1 | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | core | Version: | 1.5 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Currently the optimized selector for the document.body creates a new string for the this.selector property. It should re-use the selector variable to improve minification.
The selector variable is a ideal candidate for this as the wrapping if-statement already checks if the variable is equal to body.
Patch:
http://github.com/3rd-Eden/jquery/commit/fe47de388c0fec70273518de651ca4be5d4e2078
Attachments (0)
Change History (5)
Changed November 03, 2010 03:45PM UTC by comment:1
Changed November 03, 2010 05:44PM UTC by comment:2
| component: | selector → core |
|---|---|
| milestone: | 1.4.3 → 1.4.5 |
| priority: | → high |
| status: | new → open |
| version: | 1.4.2 → 1.4.4rc |
Changed December 30, 2010 02:51AM UTC by comment:3
| resolution: | → invalid |
|---|---|
| status: | open → closed |
The patch has disappeared.
Changed January 31, 2011 05:53PM UTC by comment:4
| version: | 1.4.4rc → 1.5 |
|---|
There wasn't a 1.4.5 release, was actually 1.5.
Changed January 31, 2011 05:54PM UTC by comment:5
| milestone: | 1.4.5 → 1.5 |
|---|
There was no 1.4.5 release, was actually 1.5.
Since the selector variable is compressed down into a single character variable, this seems like a good way to save a couple bytes, since we are already checking the value is exactly what we want.