#6704 closed enhancement (invalid)
In efficient use of the dedicated body element selector
| Reported by: | V1 | Owned by: | |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | core | Version: | 1.5 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Currently the optimized selector for the document.body creates a new string for the this.selector property. It should re-use the selector variable to improve minification.
The selector variable is a ideal candidate for this as the wrapping if-statement already checks if the variable is equal to body.
Patch: http://github.com/3rd-Eden/jquery/commit/fe47de388c0fec70273518de651ca4be5d4e2078
Change History (5)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
| Component: | selector → core |
|---|---|
| Milestone: | 1.4.3 → 1.4.5 |
| Priority: | → high |
| Status: | new → open |
| Version: | 1.4.2 → 1.4.4rc |
comment:3 Changed 9 years ago by
| Resolution: | → invalid |
|---|---|
| Status: | open → closed |
The patch has disappeared.
comment:4 Changed 9 years ago by
| Version: | 1.4.4rc → 1.5 |
|---|
There wasn't a 1.4.5 release, was actually 1.5.
comment:5 Changed 9 years ago by
| Milestone: | 1.4.5 → 1.5 |
|---|
There was no 1.4.5 release, was actually 1.5.
Note: See
TracTickets for help on using
tickets.
Since the selector variable is compressed down into a single character variable, this seems like a good way to save a couple bytes, since we are already checking the value is exactly what we want.