Bug Tracker

Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#6562 closed bug (fixed)

using .attr() to set the 'target' attribute, with a node that has ID of 'target'

Reported by: cloakedninjas Owned by: Timmy Willison
Priority: blocker Milestone: 1.6
Component: attributes Version: git
Keywords: form dom Cc:
Blocked by: Blocking:


Code to replicate is attached.

Essentially, if you have a Dom node with the ID of 'target' and you try and set a target, it fails.

If you try to just get the target attribute when there isn't one, the 'target' node is returned. If the target attribute is present, then the getter works.

If you comment out the <input> element, the code runs fine

Attachments (1)

test.html (548 bytes) - added by cloakedninjas 13 years ago.

Download all attachments as: .zip

Change History (10)

Changed 13 years ago by cloakedninjas

Attachment: test.html added

comment:1 Changed 13 years ago by tomgrohl

From what I've seen, internally jQuery is doing main_form.target (elem[ name ]) to work in all browsers, which is why the node 'target' is accessed and not the attribute.

I've found that if the type of main_form.target is not a string ( so in this case it would be a object ) you could use a different method.

I found the best way ( albeit with a for loop ) that works in all major browsers was to change line 1704 ( needs simplifying a little bit ) to:

if ( jQuery.type(elem[ name ]) === "string" )
	elem[ name ] = value;
	for ( var  i=0; i < elem.attributes.length; i++ ){
		if ( elem.attributes[i].name == name )
			elem.attributes[i].value = value;

So if the attribute it tries to access is a Dom object and not a string it uses a standard way that will work.

I've used a for loop to access the attributes as setAttribute does not work in all browsers.

comment:2 Changed 13 years ago by tomgrohl

Actually using:

elem.getAttributeNode( name ).nodeValue = value;

might be better than:

elem[ name ] = value;

to avoid cases where an element id/name can be a attribute of the same or another element. Seems to work in all browsers too.


jQuery already uses elem.getAttributeNode( name ).nodeValue for getting an attribute value when an element is a form, don't see why it can't use it for setting too.

Last edited 13 years ago by tomgrohl (previous) (diff)

comment:3 Changed 13 years ago by snover

Keywords: form dom added
Priority: undecided

This needs to be correlated with other bugs related to the DOM providing access to form elements as direct properties of the form object.

comment:4 Changed 13 years ago by snover

Keywords: needsreview added

comment:5 Changed 13 years ago by snover

Milestone: 1.4.3

Resetting milestone to future.

comment:6 Changed 13 years ago by tomgrohl

One way to is to check whether the element being accessed is a form.

In 1.5.1 something like this is done for getting an attribute, so it might be good to use for setting.

I changed from line 2062 (ish) from:

if ( value === null ) {
	if ( elem.nodeType === 1 ) {
		elem.removeAttribute( name );

} else {
	elem[ name ] = value;


if ( value === null ) {
	if ( elem.nodeType === 1 ) {
		elem.removeAttribute( name );

} else {
	if ( set && jQuery.nodeName( elem, "form" ) ) {
		elem.setAttribute( name, value );
	} else {
		elem[ name ] = value;

And it works fine. Only tested in Firefox so needs to be tested in other browsers but I believe it should work.

comment:7 Changed 13 years ago by addyosmani

#8628 is a duplicate of this ticket.

comment:8 Changed 13 years ago by Timmy Willison

Keywords: needsreview removed
Milestone: 1.6
Owner: set to Timmy Willison
Priority: undecidedblocker
Status: newassigned
Version: 1.4.2git

comment:9 Changed 12 years ago by Timmy Willison

Resolution: fixed
Status: assignedclosed
Note: See TracTickets for help on using tickets.