Bug Tracker

Opened 6 years ago

Closed 5 years ago

#6386 closed enhancement (fixed)

support data argument for live events via "event.special.live.add"

Reported by: mike.helgeson Owned by: dmethvin
Priority: low Milestone: 1.7
Component: event Version: 1.4.4
Keywords: live, 1.7-discuss Cc:
Blocked by: Blocking:

Description (last modified by dmethvin)

I am attempting to support "live" events in a custom special event, and the data object passed in the "bind" method gets passed into my special event "setup" function. This allows accepting that argument as options. This does not work with the "live" method. The "data" property is correctly set in the "live" handler "event" object, but not passed into my special event "setup" function.

It is a very small change indeed. On line 2029 of jQuery 1.4.2,in the "jQuery.event.special.live.add" function, simply add the "handleObj.data" property as the fourth argument to "jQuery.event.add". Alternatively, this could be handled within the "jQuery.event.add" method.

As a side note. I think the "liveHandler" and "liveConvert" methods, which are currently private, should be moved to the "jQuery.event.special.live" object. This would allow plugins to leverage more of the "live" features for development. I would also be able to patch the previously mentioned issue within my special event plugin, but I cannot because "liveHandler" is private.

Change History (14)

comment:1 Changed 5 years ago by snover

  • Milestone 1.4.3 deleted

Resetting milestone to future.

comment:2 Changed 5 years ago by snover

  • Milestone set to 1.5
  • Priority set to low
  • Status changed from new to open
  • Summary changed from "event.special.live.add" does not pass data argument to "event.add" to support data argument for live events via "event.special.live.add"
  • Type changed from bug to enhancement
  • Version changed from 1.4.2 to 1.4.4

If you provide a patch on GitHub, that will help to get this issue resolved more quickly.

comment:3 Changed 5 years ago by john

  • Milestone set to 1.next

Let's look at this for 1.7.

comment:4 Changed 5 years ago by john

  • Keywords 1.7-discuss added

Nominating ticket for 1.7 discussion.

comment:5 Changed 5 years ago by rwaldron

  • Description modified (diff)

+1,

comment:6 Changed 5 years ago by jaubourg

+0,

comment:7 Changed 5 years ago by ajpiano

  • Description modified (diff)

+1,

comment:8 Changed 5 years ago by timmywil

  • Description modified (diff)

+1,

comment:9 Changed 5 years ago by dmethvin

  • Description modified (diff)

+1, on allowing data in delegated events, but not on exposing liveHandler etc because I'd like to rework that.

comment:10 Changed 5 years ago by john

  • Description modified (diff)

+1, Seems simple enough.

comment:11 Changed 5 years ago by scottgonzalez

+1, sounds like a bug

comment:12 Changed 5 years ago by jzaefferer

+0

comment:13 Changed 5 years ago by dmethvin

  • Description modified (diff)
  • Milestone changed from 1.next to 1.7
  • Owner set to dmethvin
  • Status changed from open to assigned

comment:14 Changed 5 years ago by dmethvin

  • Resolution set to fixed
  • Status changed from assigned to closed

In 1.7 the data argument is available via handleObj.data. Determine whether the event is delegated or not by looking at handleObj.selector which will be undefined if it is not delegated.

Note: See TracTickets for help on using tickets.