#6355 closed bug (fixed)
clone(true) creates bogus event bindings if you extend Array.prototype
| Reported by: | airportyh | Owned by: | dmethvin |
|---|---|---|---|
| Priority: | high | Milestone: | 1.5 |
| Component: | manipulation | Version: | 1.4.3 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
If you added extra methods to Array.prototype and use jQuery.clone(true) to clone an element which has bound events, it will create bogus event bindings: one for each extra method you added to Array.prototype. The test added to test/unit/manipulation.js demonstrates this.
The patch that fixes this is at: http://github.com/airportyh/jquery/commit/5e1bc7a973ae28f19f37759662ab0ea33076125c#comment_58550
Change History (14)
comment:1 Changed 13 years ago by
comment:3 Changed 13 years ago by
| need: | Review → Commit |
|---|---|
| Priority: | → undecided |
comment:4 Changed 13 years ago by
| Status: | new → open |
|---|
comment:5 Changed 13 years ago by
| Version: | 1.4.2 → 1.4.3 |
|---|
I thought this got committed for 1.4.3 but it didn't...
comment:6 Changed 13 years ago by
| Milestone: | 1.4.3 → 1.4.4 |
|---|
comment:7 Changed 13 years ago by
| Milestone: | 1.4.4 → 1.4.5 |
|---|
comment:8 Changed 12 years ago by
Seeing as this has already got a quality patch with an adequate test, it should be easy enough to integrate?
comment:10 Changed 12 years ago by
comment:11 Changed 12 years ago by
| Owner: | set to dmethvin |
|---|---|
| Status: | open → assigned |
comment:12 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
comment:13 Changed 12 years ago by
| Milestone: | 1.4.5 → 1.5 |
|---|
Move fixed tickets to appropriate milestone
comment:14 Changed 12 years ago by
| Priority: | undecided → high |
|---|
Note: See
TracTickets for help on using
tickets.
+1. Just discovered this bug today on a site we're upgrading to 1.4.2. This did not happen under 1.3.2. It's in the cloneCopyEvent method, and affects IE.