show() hide() bug if element is hidden with css class property

[orensol]

If an element is hidden with a css class, and then you call show() and hide() on the element, it remains with a new style property of "style = 'display: none;'".

This behavior can be unwanted in some cases. hide() in this case should remove the "display" property that was added to the style attribute.

[seasoup]

Can you provide a test case?

[orensol]

Attached test-hide.html, notice how the img is first hidden with the css class .hid, and after show().hide() is called, it is hidden with the element.style.

[dmethvin]

This is intentional. Although it's easy to get the element's css display property, it is harder to know whether it's from a stylesheet or an inline style. Is there some situation where the current behavior breaks something?

[orensol]

Yes, this behavior breaks something.

If that element is hidden because a parent element is hidden, and you have code that somewhere along the way shows the parent element, this child element remains hidden, although the expected result would be it is shown.

Also, it's not that hard to know if the style is inline. (obj.attr('style').indexOf('display') > -1) should do the trick.

[snover]

Resetting milestone to future.

[snover]

Calling hide, show, css, etc. always implies a style override.