Skip to main content

Bug Tracker

Side navigation

#6205 closed bug (invalid)

Opened March 02, 2010 07:41PM UTC

Closed March 02, 2010 07:49PM UTC

Last modified March 02, 2010 08:08PM UTC

.add() not working on cached jQuery object

Reported by: markahon Owned by:
Priority: Milestone: 1.4.3
Component: traversing Version: 1.4.2
Keywords: Cc:
Blocked by: Blocking:

Can't use $.fn.add to add more elements into a cached jQuery object containing DOM elements.

If this works as intended, then at least the documentation on is not clear about this, and then why shouldn't it be allowed?

I stumbled into this when I wanted to use .add() inside a loop to add an element into a collection, if certain criteria is fulfilled. The jQuery object containing the elements that fulfilled the criteria would be processed later.

Test code:

var d = $('div');
alert('divs: '+d.length);

// using add(), this failed
d = $();
$.each($('div'), function() {
alert('divs, using add() in a loop: '+d.length);

// workaround
d = [];
$.each($('div'), function() {
alert('divs, using array workaround: '+$(d).length);
Attachments (0)
Change History (2)

Changed March 02, 2010 07:49PM UTC by john comment:1

resolution: → invalid
status: newclosed

.add() doesn't modify the existing object, it returns a new object with the values in it - it's more like using .concat() then .push.

Changed March 02, 2010 08:08PM UTC by markahon comment:2

Ah, thank you for the quick answer. This was revealing, before now it had somehow felt natural to assume that the existing object is modified when the traversing functions are used.