Skip to main content

Bug Tracker

Side navigation

#6049 closed bug (fixed)

Opened February 07, 2010 04:43PM UTC

Closed February 10, 2010 09:41PM UTC

github offline breaks development cicle

Reported by: iraebrasil Owned by:
Priority: Milestone: 1.4.2
Component: build Version: 1.4.1
Keywords: Cc:
Blocked by: Blocking:

When using "make" to build jquery, if github is offline, you get the following error:

$ make

Grabbing external dependencies...

Initialized empty Git repository in /Users/irae/source/jquery/test/qunit/.git/

fatal: The remote end hung up unexpectedly

make: *** [init] Error 128

I was with the latest version already (checked out some 10 minutes ago) but github got offline and I was unable to continuing testing.

Unfortunately I run make clean and not even commenting the line helps anymore.

Attachments (0)
Change History (4)

Changed February 07, 2010 09:03PM UTC by john comment:1

resolution: → worksforme
status: newclosed

Just run 'make jq' - I added this the other day as an alternative to the full build (thus it doesn't pull from Github).

Changed February 08, 2010 02:04AM UTC by iraebrasil comment:2

resolution: worksforme
status: closedreopened

Sorry for being persistent, but often offline people will not have access to documentation and this bug tracker to check for this orientation.

Also not many can figure out how to use make. One proficient in Javascript not always knows Makefiles.

I've made a simple patch here:

This will not affect those who never checked out, only who already had qUint and Sizzle at some point.

Changed February 08, 2010 03:26AM UTC by iraebrasil comment:3


My previous commit doesn't work all the time. This one should be final:

This time i've done much more testing.

Changed February 10, 2010 09:41PM UTC by john comment:4

resolution: → fixed
status: reopenedclosed

None of those things are stored on Github:

All of those are on jQuery servers.

I've landed your patch here: