Bug Tracker

Opened 11 years ago

Closed 11 years ago

#6049 closed bug (fixed)

github offline breaks development cicle

Reported by: iraebrasil Owned by:
Priority: Milestone: 1.4.2
Component: build Version: 1.4.1
Keywords: Cc:
Blocked by: Blocking:


When using "make" to build jquery, if github is offline, you get the following error:

$ make Grabbing external dependencies... Initialized empty Git repository in /Users/irae/source/jquery/test/qunit/.git/ fatal: The remote end hung up unexpectedly make: * [init] Error 128

I was with the latest version already (checked out some 10 minutes ago) but github got offline and I was unable to continuing testing.

Unfortunately I run make clean and not even commenting the line helps anymore.

Change History (4)

comment:1 Changed 11 years ago by john

Resolution: worksforme
Status: newclosed

Just run 'make jq' - I added this the other day as an alternative to the full build (thus it doesn't pull from Github).

comment:2 Changed 11 years ago by iraebrasil

Resolution: worksforme
Status: closedreopened

Sorry for being persistent, but often offline people will not have access to documentation and this bug tracker to check for this orientation.

Also not many can figure out how to use make. One proficient in Javascript not always knows Makefiles.

I've made a simple patch here: http://github.com/irae/jquery/commit/285541b721167fbee75e233a10e615cf9748b2fa

This will not affect those who never checked out, only who already had qUint and Sizzle at some point.

comment:3 Changed 11 years ago by iraebrasil


My previous commit doesn't work all the time. This one should be final: http://github.com/irae/jquery/commit/f411c8f25b8db80a1b8768e25860e1a3a48adf8c

This time i've done much more testing.

comment:4 Changed 11 years ago by john

Resolution: fixed
Status: reopenedclosed

None of those things are stored on Github: http://api.jquery.com/ http://dev.jquery.com/ http://docs.jquery.com/

All of those are on jQuery servers.

I've landed your patch here: http://github.com/jquery/jquery/commit/d3d497f900a559ca254d09470db532064eeacc1e

Note: See TracTickets for help on using tickets.