Side navigation
#5910 closed bug (fixed)
Opened January 23, 2010 02:15AM UTC
Closed January 23, 2010 05:25PM UTC
In 1.4, show/hide methods call animate() when speed is false or empty string
| Reported by: | kswedberg | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.4.1 |
| Component: | effects | Version: | 1.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
This isn't necessarily wrong, but it's different from previous versions, so I changed the conditional from:
if ( speed != null )
to:
if ( speed || speed === 0 )
I committed the change to my fork on Github:
http://github.com/kswedberg/jquery/commit/e708de615723fbff3d121be00c2e4da60fcc72bd
And committed some tests:
http://github.com/kswedberg/jquery/commit/a67e074225da785670a170084fbbb490a6915f1e
Attachments (0)
Change History (1)
Changed January 23, 2010 05:25PM UTC by comment:1
| component: | unfilled → fx |
|---|---|
| resolution: | → fixed |
| status: | new → closed |
Landed.
http://github.com/jquery/jquery/commit/21441b1cbc7a205e621b8c94a21eff102380ca03
http://github.com/jquery/jquery/commit/a63754aa4e4e430007208d6b5cb76f9ca8c279f5