Opened 13 years ago
Closed 13 years ago
#5798 closed bug (fixed)
replaceWith(function) scope is broken
Reported by: | ajpiano | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.4.1 |
Component: | core | Version: | 1.4 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
The context of the callback function is not right when you use replaceWith(function);
$("h3").replaceWith(function(i) {
console.log(this); 'this' will be the next sibling or the parent
});
Because replaceWith(function) ends up delegating to
jQuery(next).before(value) or jQuery(parent).append(value)
Since the current element isn't passed in as an argument or set as the context, there's presently no way to work with it in the callback. I tend to think that the current elem should be set as context, as well as passed in as an arg, to be consistent with .html(function), .text(function), etc.
Change History (1)
comment:1 Changed 13 years ago by
Component: | unfilled → core |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Fixed. http://github.com/jquery/jquery/commit/0b3165fd23ba4d240dd72f93d315bb5f7bf970e8