Bug Tracker

Opened 7 years ago

Closed 6 years ago

#5775 closed bug (worksforme)

animate uses Node.ELEMENT and not Node.ELEMENT_NODE

Reported by: wholcomb Owned by:
Priority: major Milestone: 1.4
Component: effects Version: 1.4
Keywords: Cc:
Blocked by: Blocking:

Description

The w3c spec specifies the constant for an element node is Node.ELEMENT_NODE.

​http://www.w3.org/TR/2000/REC-DOM-Level-2-Core-20001113/ecma-script-binding.html

The animate function has the line:

var hidden = this.nodeType == Node.ELEMENT && jQuery(this).is(":hidden");

This fails on documents loaded with a application/xhtml+xml mimetype in Firefox 3.5.

var hidden = (this.nodeType == Node.ELEMENT
this.nodeType == Node.ELEMENT_NODE) && jQuery(this).is(":hidden");

Works.

Change History (2)

comment:1 Changed 6 years ago by dmethvin

  • Component changed from unfiled to fx

comment:2 Changed 6 years ago by dmethvin

  • Resolution set to worksforme
  • Status changed from new to closed

Not sure where you're seeing Node.ELEMENT; in the uncompressed standard jQuery files, nodeType is compared to the actual integer value of 1 to see if it's an element node.

Note: See TracTickets for help on using tickets.