Bug Tracker

Opened 9 years ago

Closed 8 years ago

#5685 closed enhancement (invalid)

Minor optimization of jQuery.fx.step

Reported by: jixxer Owned by: jixxer
Priority: undecided Milestone: 1.4
Component: effects Version: 1.4a1
Keywords: fx step Cc:
Blocked by: Blocking:

Description

Lines 368-372 from effects.js 1.4a2

368: for ( var i in this.options.curAnim ) {
369:     if ( this.options.curAnim[i] !== true ) {
370:         done = false;
371:     }
372: }

it is unnecessary to continue the for loop once we reach line 370. Depending on the number of properties which have to be animated (default 11) this would saves a few cycles for every animated element.


Proposed "speed" batch

370a371
>         break;

Resulting code

368: for ( var i in this.options.curAnim ) {
369:     if ( this.options.curAnim[i] !== true ) {
370:         done = false;
371:         break;
372:     }
373: }

Change History (4)

comment:1 Changed 8 years ago by dmethvin

Status: newopen

comment:2 Changed 8 years ago by Rick Waldron

Owner: set to jixxer
Status: openpending

Please confirm this issue still exists

comment:3 Changed 8 years ago by Rick Waldron

Priority: trivialundecided

comment:4 Changed 8 years ago by trac-o-bot

Resolution: invalid
Status: pendingclosed

Because we get so many tickets, we often need to return them to the initial reporter for more information. If that person does not reply within 14 days, the ticket will automatically be closed, and that has happened in this case. If you still are interested in pursuing this issue, feel free to add a comment with the requested information and we will be happy to reopen the ticket if it is still valid. Thanks!

Note: See TracTickets for help on using tickets.