isPlainObject( null/undefined/window ) on IE

[Robert Katić]

On IE:

jQuery.isPlainObject( null );
// throws "'null.nodeType' is null or not an object"

jQuery.isPlainObject( undefined );
// throws "'undefined.nodeType' is null or not an object"

jQuery.isPlainObject( window );
// returns true

​Patch NOTE: With this patch isPlanarObject will work with windows too, until an global (window) constructor is not defined.

[dmethvin]

Corrected the spelling of the method name; the patch looks like a good idea.

[Robert Katić]

Replying to dmethvin:

Corrected the spelling of the method name; the patch looks like a good idea.

Thanks, but there is still an isPlanarObject at the end (ups). Too much 3D programming for this week I guess :).

[Robert Katić]

I made another mistake. On first two cases (null and undefined), isPlainObjects returns true instead of throwing an error. Anyway the patch is fixing that.

[Robert Katić]

oops, ignore my last comment!

[Robert Katić]

Recommitted patch without unrelated files.

​Patch

[john]

Landed. ​http://github.com/jquery/jquery/commit/148fb7ba8e992dd70c64cdc6a1c6f643fd1ba160

[john]

That commit wasn't enough. IE 8 was still failing so I landed some more checks: ​http://github.com/jquery/jquery/commit/67b3be24e1215609cca524ee8158fc7e6e80db93

[tswaters]

This latest fix also resolves problems with passing certain ActiveX objects... specifically "Msxml2.XSLTemplate" -- see #6488