Bug Tracker

Opened 14 years ago

Closed 11 years ago

#5568 closed bug (fixed)

Selectors behave differently with comments tags on FF/IE

Reported by: PERECil Owned by: john
Priority: high Milestone: 1.8
Component: selector Version: 1.4.4
Keywords: Cc:
Blocked by: Blocking:

Description

See test case. Basically, Firefox ignores the comments as a node in the DOM, and IE (all versions tested) seems to count the comments in the DOM.

I don't know if this behavior is intended...

Attachments (1)

test.html​ (799 bytes) - added by PERECil 14 years ago.

Download all attachments as: .zip

Change History (6)

Changed 14 years ago by PERECil

Attachment: test.html​ added

comment:1 Changed 13 years ago by jitter

Milestone: 1.4 → 1.5
Priority: major → high
Status: new → open
Version: 1.3.2 → 1.4.4

IE returns comment nodes too when getElementsByTagName("*") is used. This is a bug in Sizzle.find

​test case alerts 1 in IE 0 in all other browsers

​test case 2 shows simple case where this becomes a problem for jQuery

comment:2 Changed 12 years ago by danheberden

Milestone: → 1.next

comment:3 Changed 12 years ago by dmethvin

Triaged as valid, need to fix the gEBTN in Sizzle.find as mentioned by jitter.

comment:4 Changed 11 years ago by dmethvin

#7276 is a duplicate of this ticket.

comment:5 Changed 11 years ago by Timmy Willison

Milestone: 1.next → 1.8
Resolution: → fixed
Status: open → closed

Fixed in ​https://github.com/jquery/sizzle/commit/cdabae22dcc432a73ab8f4d2eb5279d9b3250e10#L0R457

Note: See TracTickets for help on using tickets.