ifxhighlight improved oldStyle.backgroundColor detection

[[email protected]…]

Interface's Highlight component currently has no effect unless the element it's applied to has an explicitly set background color. It would be nice if, when none is set, it traversed up the tree to find an element which did have a set background color, then removed background color completely when the effect was done.

[[email protected]…]

I recommend that this be inserted at line 36, after the declaration of z.oldStyle:

if (!z.oldStyle.backgroundColor

z.oldStyle.backgroundColor == 'transparent') {

z.oldStyle.transparent = true; var tempParent = e.parentNode; var tempBG; while (tempParent) {

tempBG = jQuery(tempParent).css('backgroundColor'); if (tempBG && tempBG != 'transparent') {

z.oldStyle.backgroundColor = tempBG; break;

} if (tempParent.nodeName == 'BODY') {

z.oldStyle.backgroundColor = '#fff'; break;

} tempParent = tempParent.parentNode;

}

}

To remove the old style, insert this at what is now line 87:

if (z.oldStyle.transparent) {

z.el.css('backgroundColor', );

}

[[email protected]…]

The formatter screwed up the line breaks. I can send the actual code if you like.

[[email protected]…]

Upon further testing, even that solution screws things up if the background color has been applied by a class which is later removed.

[[email protected]…]

Thanks for your work on this. It's doing a great job removing the style rules when the effect finishes. However, I think it would be very useful if this iterated up the tree to determine the effective background color. It looks funny when you have a background color set for the page and it changes from yellow to white, then snaps back to transparent.

[stefan]

Fixed and commited to svn

[[email protected]…]

Thanks so much.