Bug Tracker

Opened 13 years ago

Closed 13 years ago

#5434 closed enhancement (fixed)

$.fn.add( selector, context )

Reported by: Robert Katić Owned by:
Priority: major Milestone: 1.4
Component: core Version: 1.3.2
Keywords: add, context Cc:
Blocked by: Blocking:


  1. The optional context will be applied on evolving the selector.
  1. If the context argument is not given, then at lest use the same document.


Here the expected implementation:

Query.fn.add = function( selector, context ) {
    return this.pushStack( jQuery.unique( jQuery.merge(
        typeof selector === "string" ?
            jQuery( selector, context
                || this.context && this.context.ownerDocument || this.context)
                || this[0] && (this[0].ownerDocument || this[0]) ) :
            jQuery.makeArray( selector )


Change History (1)

comment:1 Changed 13 years ago by john

Resolution: fixed
Status: newclosed
The more I thought about it, the less sense "
this.context && this.context.ownerDocument" made. The .add() method should use the context specified by the root selector call.

I've implemented this change along with test cases. Thanks for the preliminary patch! http://github.com/jquery/jquery/commit/b0fe380cf89564305646bbd55d1fd7bd210fd591

Note: See TracTickets for help on using tickets.