$.extend(false, target, obj) doesn't extend target itself

[gminuses]

After executing the following code:

var target = { a: 1 }; $.extend(false, target, { a: 2 });

target is still { a: 1 };

$.extend incorrectly finds target in its definition:

var target = arguments[0]

{}

Handle a deep copy situation

if ( typeof target === "boolean" ) {

deep = target;

target = arguments[1]

{};

skip the boolean and the target i = 2;

}

[gminuses]

It has line-breaking issues, repost:

After executing the following code:

var target = { a: 1 }; $.extend(false, target, { a: 2 });

target is still { a: 1 };

$.extend incorrectly finds target in its definition:

var target = arguments[0] {}

// Handle a deep copy situation
if ( typeof target === "boolean" ) {

    deep = target;

    target = arguments[1] {}; 
    // skip the boolean and the target
    i = 2;

}

[gminuses]

It can be easily fixed by just removing "|| {}":

var target = arguments[0], ...

The validation of target will be checked in its following code:

if ( typeof target !== "object" && !jQuery.isFunction(target) )
	target = {};

[Rick Waldron]

Please distill this into a reduced test case on jsFiddle, thanks

[trac-o-bot]

Automatically closed due to 14 days of inactivity.