jQuery.isObject, changeset 6442

[balazs.endresz]

​http://dev.jquery.com/changeset/6442

isObject: function( obj ) { 
  return this.constructor.call(obj) === Object; 
}, 

I might be missing something but after staring at this for a while, still seems to be quite odd:

-- First, this is a static method, in which using this is quite dangerous, as someone might save the function in a local variable, where this will be a reference to the window object

-- this here basically refers to jQuery

-- so this.constructor refers to Function

-- you call it in another context and it will return Object, the Object constructor???

If it's not just a typo I'd be really curious how is this supposed to work :)

[dmethvin]

Best to ask this on the jQuery Dev forum.

[balazs.endresz]

​http://groups.google.com/group/jquery-dev/browse_thread/thread/c0e4d269e9f2813d

[lrbabe]

There is definitely something wrong with this function. Do we actually need it? It is used only once in the code in jQuery.extend and there is another problem with this code, replacing the test using jQuery.isObject with false doesn't break the code. All tests of jQuery.extend still pass. I suggest fixing jQuery.extend and getting rid of jQuery.isObject if possible.

[john]

This method is gone if favor of the improved isObjectLiteral. ​http://github.com/jquery/jquery/commit/c2bbcd88335cf6f8df4ac9389ecbae90291377fb