Bug Tracker

Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#4741 closed bug (wontfix)

Toggle Performance Decreased for Tables

Reported by: JonBrunt Owned by:
Priority: low Milestone:
Component: effects Version: 1.4.4rc
Keywords: Cc:
Blocked by: Blocking:

Description

The performance of the toggle command has slowed down quite a bit since upgrading from 1.3.1 to 1.3.2 when applied to columns in a table. The effect becomes much more pronounced as the size of the table grows. I've tested this out in FF3, IE6 and IE7.

I've included two sample pages with one using 1.3.1 and 1.3.2 to illustrate the difference.

Attachments (2)

toggle_slow_1.3.2.html​ (4.6 KB) - added by JonBrunt 10 years ago.
Slow - 1.3.2
toggle_fast_1.3.1.html​ (4.6 KB) - added by JonBrunt 10 years ago.
Fast - 1.3.1

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by JonBrunt

Attachment: toggle_slow_1.3.2.html​ added

Slow - 1.3.2

Changed 10 years ago by JonBrunt

Attachment: toggle_fast_1.3.1.html​ added

Fast - 1.3.1

comment:1 Changed 9 years ago by dmethvin

Component: unfiled → fx

comment:2 Changed 9 years ago by snover

Keywords: needsreview added
Milestone: 1.3.2
Priority: major → low
Version: 1.3.2 → 1.4.4rc

22ms in 1.3.1; 133ms in 1.3.2+ (including 1.4.4rc1). Not sure if there is actually anything we can do to speed this back up again since I would guess the slowness is due to additional required checks.

comment:3 Changed 9 years ago by dmethvin

Resolution: → wontfix
Status: new → closed

I don't see this as a common case. It would be better to optimize this case in the page. If you need to toggle all rows, toggle the table. If you need to toggle known *groups* of rows, consider putting them into separate tbodies.

comment:4 Changed 9 years ago by dmethvin

Keywords: toggle table performance needsreview removed
Note: See TracTickets for help on using tickets.