Bug Tracker

Opened 11 years ago

Closed 11 years ago

Last modified 10 years ago

#474 closed bug (fixed)

oneclick with return false doesn't return false svn $Rev: 670 $

Reported by: jakecigar@… Owned by:
Priority: major Milestone:
Component: core Version:
Keywords: click callback svn Cc: jörn
Blocked by: Blocking:

Description

I use oneclick() on an a and inside the callback I return false, to not execute the a.

when I upgraded to the latest svn version... it seems not to be returning my false, the a is invoked and I leave my page.

it worked on $Rev: 415 $ (and still does work with 415)

the callback code was pared down to an alert and a return false, it still doesn't work.

Change History (3)

comment:1 Changed 11 years ago by jakecigar@…

bug found at line 1551 of event.js

f.apply(this, arguments);

should be

return f.apply(this, arguments);

Please verify and commit.

THANKS

comment:2 Changed 11 years ago by jakecigar@…

not sure that is enough... I've stopped using oneclick. I liked the old code better!

comment:3 Changed 11 years ago by joern

Resolution: fixed
Status: newclosed

Fixed in SVN, adding the return statement fixed the problem.

Note: See TracTickets for help on using tickets.