Bug Tracker

Opened 11 years ago

Closed 11 years ago

#4539 closed bug (fixed)

live with context in jquery nightly

Reported by: trixi Owned by: brandon
Priority: major Milestone: 1.4
Component: event Version: 1.3.2
Keywords: Cc:
Blocked by: Blocking:

Description

You have added support for live with a different context than document (see here: http://dev.jquery.com/ticket/4189), but the fix is not complete yet. If a parent element of the choosen context also matches the given selector-string, the live event will also fire.

I have added two patches for this.

Attachments (3)

event-live-context.patch (784 bytes) - added by trixi 11 years ago.
closest-live-context.patch (776 bytes) - added by trixi 11 years ago.
closest-context.patch (650 bytes) - added by jollytoad 11 years ago.
Restrict closest to search only within the jQuery context

Download all attachments as: .zip

Change History (5)

Changed 11 years ago by trixi

Attachment: event-live-context.patch added

Changed 11 years ago by trixi

Attachment: closest-live-context.patch added

Changed 11 years ago by jollytoad

Attachment: closest-context.patch added

Restrict closest to search only within the jQuery context

comment:1 Changed 11 years ago by jollytoad

Good catch.

This has made me think that closest should be restricted to not traverse higher than the current jQuery context anyway - I attached a patch for this. And maybe the same should apply for other upward traversals too, ie. parent/parents.

Ah, I've just discovered this is not such a good idea. As jQuery doesn't accept an element as selector and context, so the following wouldn't work:

$(event.target, context).closest('.something')

Ok, ignore my patch! I'd remove it but can't find a way to in trac!

comment:2 Changed 11 years ago by john

Resolution: fixed
Status: newclosed

It looks like this was landed as part of the recent live commits.

Note: See TracTickets for help on using tickets.