Error when calling jQuery.trim

[buchi]

Calling: jQuery.trim(1)

results in:

Error: (text

"").replace is not a function

Source: jquery-1.3.2.js, Line: 1067

IMHO this should return "1"

[dmethvin]

What should it return on an object, function, regexp, or date object? In some cases it's just best to give the user an error asap.

[buchi]

Maybe you know it better than I and you're right when passing other objects to jQuery.trim, but in case of an integer it could return the string version of this integer. So the trim-regex won't be needed. I wanted to discuss this behaviour because I got the mentioned error and at first I had no idea what was wrong. Other functions also handle integers like strings, e.g. alert("123") does the same as alert(123)

[john]

Fixed. ​http://github.com/jquery/jquery/commit/141ad3c3e21e7734e67e37b5fb39782fe11b3c18