Skip to main content

Bug Tracker

Side navigation

#4276 closed enhancement (duplicate)

Opened March 02, 2009 03:24AM UTC

Closed May 04, 2009 02:29AM UTC

height/width cleanup

Reported by: mike.helgeson Owned by: brandon
Priority: minor Milestone: 1.4
Component: dimensions Version: 1.3.2
Keywords: Cc:
Blocked by: Blocking:

The changes recently made to improve the height/width methods left behind some unused code, and some duplicate code. The attached file is from r6195...

I removed the unused "tl" and "br" variables.

I removed the "type" variable (which is exactly the same as "lower"), and replaced all usage of "type" with "lower."

I added a property lookup to the "height" and "width" methods. Currently if the "size" argument is undefined, the method is a getter. With this change, as a getter, the argument can be "padding" or "border" or "margin" or undefined. This allows the same behavior as achieved by the "inner..." and "outer..." methods.

Attachments (1)
Change History (2)

Changed May 04, 2009 02:17AM UTC by brandon comment:1

component: coredimensions
owner: → brandon

Changed May 04, 2009 02:29AM UTC by brandon comment:2

resolution: → duplicate
status: newclosed

The dimensions module has since been cleaned up.