Bug Tracker

Opened 8 years ago

Closed 8 years ago

#4270 closed bug (fixed)

Remove the use of nonstandard properties leftContext and rightContext

Reported by: metaweta Owned by: john
Priority: major Milestone: 1.4
Component: selector Version: 1.3.2
Keywords: Cc:
Blocked by: Blocking:

Description

Removes the dependence on the nonstandard RegExp properties leftContext and rightContext. Also removes the dependence on lastIndex, which can't be exposed in Caja because it is static shared state, which leaks information across gadget boundaries.

Attachments (1)

sizzle.diff​ (2.1 KB) - added by metaweta 8 years ago.

Download all attachments as: .zip

Change History (4)

comment:1 Changed 8 years ago by metaweta

Sorry, this patch only removes rightContext. Will follow up with a patch removing leftContext and lastIndex.

comment:2 Changed 8 years ago by metaweta

OK, patch corrected. The attached patch now does what the original description says.

Changed 8 years ago by metaweta

Attachment: sizzle.diff​ added

comment:3 Changed 8 years ago by john

Resolution: → fixed
Status: new → closed

Fixed in Sizzle. ​http://github.com/jeresig/sizzle/commit/2f1f9a1795c6790983d583155354da984d433ef6

Note: See TracTickets for help on using tickets.