Opened 14 years ago
Closed 13 years ago
#4251 closed bug (fixed)
Use new when constructing RegExps and named functions instead of arguments.callee
Reported by: | metaweta | Owned by: | brandon |
---|---|---|---|
Priority: | major | Milestone: | 1.4 |
Component: | event | Version: | 1.3.2 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
ECMAScript 3.1 strict mode will prohibit the use of arguments.callee. Recursive anonymous functions will need to be named and invoked by name. As long as this happens within a closure, as is the case with support.js, this won't pollute the global namespace on IE.
Also, in order to make jQuery work with Caja, constructors must be invoked with new, not called directly.
Attachments (3)
Change History (9)
Changed 14 years ago by
Attachment: | jquery.diff added |
---|
comment:1 Changed 14 years ago by
Component: | unfilled → core |
---|---|
Resolution: | → fixed |
Status: | new → closed |
Landed in SVN rev [6262]. Thanks for the patch!
Changed 14 years ago by
Attachment: | jquery.2.diff added |
---|
Patch for events.js removing the use of arguments.callee
comment:2 Changed 14 years ago by
Sorry to reopen the bug. Somehow, I missed the uses of arguments.callee in event.js. Find attached a patch (jquery.2.diff) that fixes that.
comment:3 Changed 14 years ago by
Resolution: | fixed |
---|---|
Status: | closed → reopened |
comment:4 Changed 14 years ago by
Component: | core → event |
---|---|
Owner: | set to brandon |
Status: | reopened → new |
comment:5 Changed 14 years ago by
Status: | new → assigned |
---|
Need to make sure this doesn't bring back the memory leak referenced on line 47 of event.js before committing.
Patch fixing the bug.