Skip to main content

Bug Tracker

Side navigation

#4207 closed bug (worksforme)

Opened February 21, 2009 11:36PM UTC

Closed February 23, 2009 02:58PM UTC

Last modified February 23, 2009 09:22PM UTC

toggleClass does not read the state argument

Reported by: janrito Owned by:
Priority: major Milestone: 1.4
Component: core Version: 1.3.2
Keywords: toggleClass Cc: janrito, flesler
Blocked by: Blocking:
Description

The toggleClass second argument does not read the state argument. Right now toggleClass will remove the class if the element has it, and add it if the element does not.

That functionality is ok, but it should also add the class if state is true, and remove the class if state is false.

Attachments (0)
Change History (3)

Changed February 23, 2009 02:58PM UTC by flesler comment:1

need: ReviewTest Case
resolution: → worksforme
status: newclosed

This is working since 1.3.0.

Reopen with a test case if you think something's still broken.

Changed February 23, 2009 02:58PM UTC by flesler comment:2

cc: → janrito, flesler

Changed February 23, 2009 09:22PM UTC by janrito comment:3

Found the problem:

I was using jQuery ui 1.5.1. ui.effects.core.js redefines toggleClass, and was not passing the second argument.