#4207 closed bug (worksforme)
toggleClass does not read the state argument
| Reported by: | janrito | Owned by: | |
|---|---|---|---|
| Priority: | major | Milestone: | 1.4 |
| Component: | core | Version: | 1.3.2 |
| Keywords: | toggleClass | Cc: | janrito, flesler |
| Blocked by: | Blocking: |
Description
The toggleClass second argument does not read the state argument. Right now toggleClass will remove the class if the element has it, and add it if the element does not. That functionality is ok, but it should also add the class if state is true, and remove the class if state is false.
Change History (3)
comment:1 Changed 14 years ago by
| need: | Review → Test Case |
|---|---|
| Resolution: | → worksforme |
| Status: | new → closed |
comment:2 Changed 14 years ago by
| Cc: | janrito flesler added |
|---|
comment:3 Changed 14 years ago by
Found the problem:
I was using jQuery ui 1.5.1. ui.effects.core.js redefines toggleClass, and was not passing the second argument.
Note: See
TracTickets for help on using
tickets.
This is working since 1.3.0. Reopen with a test case if you think something's still broken.