Bug Tracker

Opened 11 years ago

Closed 11 years ago

#4092 closed bug (invalid)

documentation demo problem

Reported by: initjh Owned by:
Priority: minor Milestone: 1.3.2
Component: docs Version: 1.3.1
Keywords: accordion documentation Cc:
Blocked by: Blocking:

Description

http://docs.jquery.com/UI/Accordion

Note: Could not find documentation or site related issues for jQuery UI tracker, so I posted it here. Also, the demo creator is site-wide, so it seems to make most sense here.

The script only replaces $(document).ready(), not $(). The Accordion example uses $(), and because you are inserting try/catch, the whole thing fails.

Also, why are you using window.onload= rather than $(window).load()?

Change History (4)

comment:1 Changed 11 years ago by initjh

To note, it may be the Accordion UI docs at fault here.

I tried my hand at fixing the docs myself, and deleted a piece of code that is inconsistent with the general jQuery doc format.

I then realized that somebody rather recently hacked up the Accordion UI docs with non-matching and "test" code. Most of it is difficult to follow and inconsistent.

Is there any way to roll back the documentation, at least a couple months back?

comment:2 Changed 11 years ago by initjh

The code I removed was this:

<script type="text/javascript"> $(function() {

$("#accordion").accordion({

header: "h3"

});

}); </script>

Which is tripping up a regex used to insert window.onload.

comment:3 Changed 11 years ago by initjh

Okay, I fixed the demo so that it looks nice, and matches the state it was in before I edited it (using the "h3" header).

Although, this seems to be too complex a demo. Using a header option, as well as the complicated and long markup, will probably turn away many a newbie.

This goes for the rest of the Accordion docs (on the next page). I really think someone needs to overhaul the whole thing, or roll it back to an older state.

comment:4 Changed 11 years ago by dmethvin

Resolution: invalid
Status: newclosed

Thanks, I'm not sure what's happened on that page but I see what you mean. The UI folks are hard at work on a new release, and the page may just be in need of some syncing with jQuery 1.3.1. Can you open a bug on the UI bug tracker?

http://dev.jqueryui.com/report/10?P=accordion

Note: See TracTickets for help on using tickets.