Bug Tracker

Opened 12 years ago

Closed 12 years ago

#4001 closed bug (fixed)

setInterval leak in function custom

Reported by: arrix Owned by:
Priority: major Milestone: 1.3.2
Component: effects Version: 1.3.1
Keywords: Cc:
Blocked by: Blocking:

Description

jQuery.fx.prototype.custom uses jQuery.timers.push(t) == 1 as a guard condition for the setInterval call, which is not robust enough. In the test case, stop, which empties jQuery.timers, is called before animate so that the check will pass even though there is already an active interval. This causes a leak because timerId gets overwritten every time and there is no way to clearInterval.

Attachments (2)

animation_guard.html (905 bytes) - added by arrix 12 years ago.
fx_interval.patch (490 bytes) - added by arrix 12 years ago.

Download all attachments as: .zip

Change History (3)

Changed 12 years ago by arrix

Attachment: animation_guard.html added

Changed 12 years ago by arrix

Attachment: fx_interval.patch added

comment:1 Changed 12 years ago by john

Resolution: fixed
Status: newclosed

Fixed in SVN rev [6194].

Note: See TracTickets for help on using tickets.