Some UI effects fail in 1.3

[kbwood]

In upgrading to 1.3 I noted that several of the UI effects (such as bounce and fold) no longer work correctly. After some testing I noted the following combinations:

1.2.6 and UI 1.5.3 - works

1.2.6 and UI 1.6rc5 - works

1.3 and UI 1.5.3 - doesn't work

1.3 and UI 1.6rc5 - doesn't work

Thus there has been some change between 1.2.6 and 1.3 that has broken these animations. The animation seems to stop half way through without raising an apparent error. This leaves the animated division in a non-displayable state.

[kbwood]

Testing harness with datepicker and animations

[kbwood]

I've traced the problem to the speed function. When this is passed a speed value that is NaN it passes that through to the animation. This is because typeof (NaN) evaluates to 'number', which it isn't. So I think the test should be:

opt.duration = jQuery.fx.off ? 0 :

typeof opt.duration === "number" && !isNaN(opt.duration) ? opt.duration :

jQuery.fx.speeds[opt.duration]

jQuery.fx.speeds._default;

[kbwood]

There should be two vertical bars between the two values on the last line of code - they don't seem to show up!

[scottgonzalez]

This has been fixed in UI, see ​UI #3912.

[dmethvin]

Fixed in UI.