Opened 14 years ago
Closed 12 years ago
#3946 closed bug (fixed)
Some UI effects fail in 1.3
Reported by: | kbwood | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.3.1 |
Component: | effects | Version: | 1.3 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description (last modified by )
In upgrading to 1.3 I noted that several of the UI effects (such as bounce and fold) no longer work correctly. After some testing I noted the following combinations:
1.2.6 and UI 1.5.3 - works
1.2.6 and UI 1.6rc5 - works
1.3 and UI 1.5.3 - doesn't work
1.3 and UI 1.6rc5 - doesn't work
Thus there has been some change between 1.2.6 and 1.3 that has broken these animations. The animation seems to stop half way through without raising an apparent error. This leaves the animated division in a non-displayable state.
Attachments (1)
Change History (7)
Changed 14 years ago by
Attachment: | animtest.html added |
---|
comment:1 Changed 14 years ago by
Description: | modified (diff) |
---|
comment:2 Changed 14 years ago by
I've traced the problem to the speed function. When this is passed a speed value that is NaN it passes that through to the animation. This is because typeof (NaN) evaluates to 'number', which it isn't. So I think the test should be:
opt.duration = jQuery.fx.off ? 0 :
typeof opt.duration === "number" && !isNaN(opt.duration) ? opt.duration :
jQuery.fx.speeds[opt.duration] jQuery.fx.speeds._default;
comment:3 Changed 14 years ago by
There should be two vertical bars between the two values on the last line of code - they don't seem to show up!
comment:5 Changed 14 years ago by
Component: | unfilled → fx |
---|
Testing harness with datepicker and animations