#3666 closed enhancement (fixed)
Remove dead code from $(fn) shortcut for $(document).ready(fn)
Reported by: | geary | Owned by: | flesler |
---|---|---|---|
Priority: | trivial | Milestone: | 1.3 |
Component: | core | Version: | 1.2.6 |
Keywords: | Cc: | geary | |
Blocked by: | Blocking: |
Description
The code for the $(fn) shortcut is:
return jQuery( document )[ jQuery.fn.ready ? "ready" : "load" ]( selector );
It's unclear what the intent of this code was, but the jQuery.fn.ready test has no effect. jQuery.fn.ready always exists, so the code is the equivalent of:
return jQuery( document ).ready( selector );
That also matches people's expectation that $(fn) is the exact equivalent of $(document).ready(fn).
The attached patch removes this dead code.
Attachments (1)
Change History (4)
Changed 14 years ago by
Attachment: | readyshortcut.patch added |
---|
comment:1 Changed 14 years ago by
Cc: | geary added |
---|---|
Owner: | set to flesler |
Status: | new → assigned |
comment:2 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Applied at [5997]. Thanks.
comment:3 Changed 14 years ago by
Type: | bug → enhancement |
---|
Note: See
TracTickets for help on using
tickets.
Patch to remove dead code from $(fn)