Bug Tracker

Opened 9 years ago

Closed 9 years ago

Last modified 5 years ago

#3601 closed bug (duplicate)

Mismatch parameters count passed to jQuery.easing.linear() or jQuery.easing.swing()

Reported by: DanielKatz Owned by:
Priority: minor Milestone: 1.3
Component: effects Version: 1.2.6
Keywords: easing, parameters Cc: DanielKatz, flesler
Blocked by: Blocking:

Description

In some cases mismatch parameters count passed to jQuery.easing.linear() or jQuery.easing.swing() and causing an exception. Test case is provided.

(at the line: this.pos = jQuery.easing[this.options.easing
(jQuery.easing.swing ? "swing" : "linear")](this.state, n, 0, 1, this.options.duration);)

Attachments (3)

jquery_bug_test_case.htm (1.5 KB) - added by DanielKatz 9 years ago.
bug TestCase
jquerybug.rar (29.4 KB) - added by DanielKatz 9 years ago.
Simpler test case
Ticket #3601.patch (544 bytes) - added by DanielKatz 9 years ago.
this fixes the case where the callback function is defined in another iframe

Download all attachments as: .zip

Change History (10)

Changed 9 years ago by DanielKatz

Attachment: jquery_bug_test_case.htm added

bug TestCase

comment:1 Changed 9 years ago by flesler

Cc: DanielKatz flesler added
Component: unfilledfx
need: ReviewTest Case
Owner: flesler deleted
Priority: blockerminor

The test case is really not a good one. The whole iframe+string manipulation can lead to unreal situations.

can you make one that reproduces the error, with a simple html file with no iframes and stuff like that ?

comment:2 in reply to:  1 Changed 9 years ago by DanielKatz

Replying to flesler:

The test case is really not a good one. The whole iframe+string manipulation can lead to unreal situations.

can you make one that reproduces the error, with a simple html file with no iframes and stuff like that ?

I'l try. but i think this the only case. and it's obviously bug in jQuery because this exception occures on every browser... And logicaly the iframe doesn't make any difference.

Changed 9 years ago by DanielKatz

Attachment: jquerybug.rar added

Simpler test case

comment:3 in reply to:  1 Changed 9 years ago by DanielKatz

Replying to flesler:

The test case is really not a good one. The whole iframe+string manipulation can lead to unreal situations.

can you make one that reproduces the error, with a simple html file with no iframes and stuff like that ?

I've wrote slightly simpler test case it's attached to the ticket.

comment:4 Changed 9 years ago by flesler

need: Test CaseReview

Ok then, so the problem is related to iframes.

That's something you don't mention anywhere in the whole ticket.

comment:5 in reply to:  4 Changed 9 years ago by DanielKatz

Replying to flesler:

Ok then, so the problem is related to iframes.

That's something you don't mention anywhere in the whole ticket.

Yes it is. And if I'd know how to update the description I would. sorry.

comment:6 in reply to:  description Changed 9 years ago by DanielKatz

Replying to DanielKatz:

In some cases mismatch parameters count passed to jQuery.easing.linear() or jQuery.easing.swing() and causing an exception. Test case is provided.

(at the line: this.pos = jQuery.easing[this.options.easing
(jQuery.easing.swing ? "swing" : "linear")](this.state, n, 0, 1, this.options.duration);)

Allegedly the bug appears only the code executes in context of onload event of IFrame.

Changed 9 years ago by DanielKatz

Attachment: Ticket #3601.patch added

this fixes the case where the callback function is defined in another iframe

comment:7 Changed 9 years ago by john

Resolution: duplicate
Status: newclosed

I'm going to close this as a duplicate of #3618 - because we really should fix .constructor use everywhere in jQuery.

Note: See TracTickets for help on using tickets.