Bug Tracker

Opened 11 years ago

Closed 9 years ago

#3565 closed bug (invalid)

ajax.js:httpData patch for failing JSON eval()

Reported by: robman Owned by:
Priority: low Milestone: 1.3
Component: ajax Version: 1.2.6
Keywords: httpData JSON Cc:
Blocked by: Blocking:

Description

BUG: httpData: function in ajax.js (used by getJSON() calls or get() calls where type == "json") doesn't currently test the eval is successful.

e.g. it just assumes that valid JSON was returned and eval will succeed, silently failing if this is the case.

FIX: Here's a patch to bring it in line with the other functions above.

e.g. httpSuccess and httpNotModified

NOTE: Let me know if there's a more "preferred" way to handle this error

DIFF against 1.2.6 from svn: see attached patch file

Attachments (1)

httpData.patch (759 bytes) - added by robman 11 years ago.
DIFF against 1.2.6 from svn

Download all attachments as: .zip

Change History (2)

Changed 11 years ago by robman

Attachment: httpData.patch added

DIFF against 1.2.6 from svn

comment:1 Changed 9 years ago by Rick Waldron

Priority: majorlow
Resolution: invalid
Status: newclosed

This issue is not valid as jQuery no longer uses eval for JSON parsing.

Note: See TracTickets for help on using tickets.