Skip to main content

Bug Tracker

Side navigation

#3565 closed bug (invalid)

Opened November 02, 2008 12:37AM UTC

Closed October 24, 2010 10:55PM UTC

ajax.js:httpData patch for failing JSON eval()

Reported by: robman Owned by:
Priority: low Milestone: 1.3
Component: ajax Version: 1.2.6
Keywords: httpData JSON Cc:
Blocked by: Blocking:
Description

BUG:

httpData: function in ajax.js (used by getJSON() calls or get() calls

where type == "json") doesn't currently test the eval is successful.

e.g. it just assumes that valid JSON was returned and eval will succeed,

silently failing if this is the case.

FIX:

Here's a patch to bring it in line with the other functions above.

e.g. httpSuccess and httpNotModified

NOTE: Let me know if there's a more "preferred" way to handle this error

DIFF against 1.2.6 from svn:

see attached patch file

Attachments (1)
  • httpData.patch (0.7 KB) - added by robman November 02, 2008 12:38AM UTC.

    DIFF against 1.2.6 from svn

Change History (1)

Changed October 24, 2010 10:55PM UTC by rwaldron comment:1

priority: majorlow
resolution: → invalid
status: newclosed

This issue is not valid as jQuery no longer uses eval for JSON parsing.