Bug Tracker

Opened 9 years ago

Closed 9 years ago

#3355 closed feature (fixed)

Add stopImmediatePropagation to event objects

Reported by: flesler Owned by: flesler
Priority: minor Milestone: 1.3
Component: event Version: 1.2.6
Keywords: stopimmediatepropagation Cc: john, joern, brandon, davidserduke
Blocked by: Blocking:

Description

We got requests in the past, for a way to stop the execution of other handlers from within one.

I realize this could be easily done, by extending event objects with a method that is already a standard (DOM 3 events, included in AS3).

Check ​this and ​this for additional info.

Attachments (1)

stopImmediatePropagation[5843].diff​ (1.6 KB) - added by flesler 9 years ago.
Uses the expando to modify the event objects, doesn't break old code.

Download all attachments as: .zip

Change History (7)

Changed 9 years ago by flesler

Attachment: stopImmediatePropagation[5843].diff​ added

Uses the expando to modify the event objects, doesn't break old code.

comment:1 Changed 9 years ago by flesler

Related:

#2610, #1948, #399.

comment:3 Changed 9 years ago by joern

Good concept that fixes an annoying issue.

The patch could be improved a bit by replacing the "event[expando] == -1" bit with something more clear. Use a value that makes it obvious that its related to event propagation, not a magic number like -1.

comment:4 Changed 9 years ago by nathanhammon

Yes please. This is definitely something worth adding.

comment:5 Changed 9 years ago by flesler

The expando shouldn't be a number higher than 0, or could be misused by jQuery.data. Could be a string... but what for, it's just longer/heavier.

What would you propose Joern ?

comment:6 Changed 9 years ago by flesler

need: Review → Commit
Status: new → assigned

comment:7 Changed 9 years ago by flesler

Resolution: → fixed
Status: assigned → closed

Applied at [5892].

Note: See TracTickets for help on using tickets.