Opened 14 years ago
Closed 14 years ago
#3355 closed feature (fixed)
Add stopImmediatePropagation to event objects
Reported by: | flesler | Owned by: | flesler |
---|---|---|---|
Priority: | minor | Milestone: | 1.3 |
Component: | event | Version: | 1.2.6 |
Keywords: | stopimmediatepropagation | Cc: | john, joern, brandon, davidserduke |
Blocked by: | Blocking: |
Attachments (1)
Change History (7)
Changed 14 years ago by
Attachment: | stopImmediatePropagation[5843].diff added |
---|
comment:3 Changed 14 years ago by
Good concept that fixes an annoying issue.
The patch could be improved a bit by replacing the "event[expando] == -1" bit with something more clear. Use a value that makes it obvious that its related to event propagation, not a magic number like -1.
comment:5 Changed 14 years ago by
The expando shouldn't be a number higher than 0, or could be misused by jQuery.data. Could be a string... but what for, it's just longer/heavier.
What would you propose Joern ?
comment:6 Changed 14 years ago by
need: | Review → Commit |
---|---|
Status: | new → assigned |
Note: See
TracTickets for help on using
tickets.
Uses the expando to modify the event objects, doesn't break old code.