Bug Tracker

Opened 14 years ago

Closed 12 years ago

#3346 closed enhancement (worksforme)

empty and remove methods are too aggressive with event removal

Reported by: mike.helgeson Owned by: flesler
Priority: minor Milestone: 1.3
Component: core Version: 1.2.6
Keywords: empty remove Cc: mike.helgeson
Blocked by: Blocking:


When these methods were modified to remove events, I found that a lot of code was broken. I am submitting a patch to have an additional argument to each of these methods to preserve events. API similar to "clone(true)"... the new calls are "remove(false)" and "remove(selector,false)" and "empty(false)" The "false" argument means DO NOT remove these events.

Attachments (1)

remove_empty_patch.js (846 bytes) - added by mike.helgeson 14 years ago.

Download all attachments as: .zip

Change History (4)

Changed 14 years ago by mike.helgeson

Attachment: remove_empty_patch.js added

comment:1 Changed 14 years ago by flesler

Cc: mike.helgeson added
need: ReviewPatch
Owner: set to flesler
Status: newassigned

comment:2 Changed 14 years ago by mpaineau

I think that this enhancement is very important. Why not to include it in the 1.3.3 Milestone ? Thanks

comment:3 Changed 12 years ago by snover

Resolution: worksforme
Status: assignedclosed

Use $.fn.detach.

Note: See TracTickets for help on using tickets.