Opened 10 years ago
Closed 8 years ago
#3346 closed enhancement (worksforme)
empty and remove methods are too aggressive with event removal
| Reported by: | mike.helgeson | Owned by: | flesler |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.3 |
| Component: | core | Version: | 1.2.6 |
| Keywords: | empty remove | Cc: | mike.helgeson |
| Blocked by: | Blocking: |
Description
When these methods were modified to remove events, I found that a lot of code was broken. I am submitting a patch to have an additional argument to each of these methods to preserve events. API similar to "clone(true)"... the new calls are "remove(false)" and "remove(selector,false)" and "empty(false)" The "false" argument means DO NOT remove these events.
Attachments (1)
Change History (4)
Changed 10 years ago by
| Attachment: | remove_empty_patch.js added |
|---|
comment:1 Changed 10 years ago by
| Cc: | mike.helgeson added |
|---|---|
| need: | Review → Patch |
| Owner: | set to flesler |
| Status: | new → assigned |
comment:2 Changed 10 years ago by
comment:3 Changed 8 years ago by
| Resolution: | → worksforme |
|---|---|
| Status: | assigned → closed |
Use $.fn.detach.
Note: See
TracTickets for help on using
tickets.
I think that this enhancement is very important. Why not to include it in the 1.3.3 Milestone ? Thanks