Bug Tracker

Opened 11 years ago

Closed 10 years ago

#3331 closed bug (fixed)

curCSS() doesn't convert negative em/% values properly in IE

Reported by: jeff_themovie Owned by: flesler
Priority: major Milestone: 1.4
Component: core Version: 1.3.2
Keywords: Cc: jeff_themovie
Blocked by: Blocking:

Description

This is because line 920:

if ( !/\d+(px)?$/i.test( ret ) && /\d/.test( ret ) ) {

doesn't accept negative values. I suggest:

if ( !/-?\d+(px)?$/i.test( ret ) && /-?\d/.test( ret ) ) {

Attachments (2)

curCSS.patch​ (555 bytes) - added by jeff_themovie 11 years ago.
testcase.html​ (1.1 KB) - added by jeff_themovie 10 years ago.
test case - notice what happens when the red box is hidden in IE

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by flesler

Cc: jeff_themovie added
Component: core → event
need: Review → Patch
Owner: set to flesler
Status: new → assigned

Changed 11 years ago by jeff_themovie

Attachment: curCSS.patch​ added

comment:2 Changed 11 years ago by jeff_themovi

Patch attached. (The regex carets in the ticket description went missing for some reason...)

comment:3 Changed 11 years ago by jeff_themovi

Is there anything I should do to get the resolution process going?

Changed 10 years ago by jeff_themovie

Attachment: testcase.html​ added

test case - notice what happens when the red box is hidden in IE

comment:4 Changed 10 years ago by john

Component: event → core
Milestone: 1.3 → 1.4
Version: 1.2.6 → 1.3.2

comment:5 Changed 10 years ago by john

Resolution: → fixed
Status: assigned → closed

Fixed. ​http://github.com/jquery/jquery/commit/aae0617c834a030902cd8da2714f852d6a1431be

Note: See TracTickets for help on using tickets.